-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Upgrade the go.etcd.io/etcd
dependency to v3.4.34
#795
Conversation
d2da99e
to
42eb324
Compare
42eb324
to
ddee364
Compare
ddee364
to
492d213
Compare
492d213
to
3dc9bbd
Compare
3dc9bbd
to
96b335f
Compare
go.etcd.io/etcd
dependency to v3.4.34
, and all other direct dependenciesgo.etcd.io/etcd
dependency to v3.4.34
* Upgrade `go.etcd.io/etcd` to `v3.4.34`. * Remove all `replace` directives which locked versions of dependencies.
* Use the `Restore` API provided by the `clientv3/snapshot` package, and remove copied code for performing restoration of the etcd database from the base snapshot. * The temporary directory to persist full and delta snapshots in created at the start of the `Restore()` call. This was created only before deltas were fetched previously. * Base full snapshot is also now stored in the `TempSnapshotDir`. * It is now assumed that the etcd data directory, which is typically `default.etcd` itself is not present before restoration, and not just the `member` directory. * Unit tests are adapted accordingly such that the etcd data directory is removed before restoration. --------- Co-authored-by: Seshachalam Yerasala Venkata <[email protected]>
…estore API does it. * Restoration through the `Restore` API will fail if a directory for the database is already present. Due to this, explicitly creating a directory before restoration is triggerred is not performed anymore. The `Restore` call creates the directory. Cleanup of this directory is still performed, as a deferred call. * Fix broken unit tests in `pkg/compactor`.
96b335f
to
90087a7
Compare
It appears that we are currently referencing etcd version 3.4.13 in the following files:
Could you please update these references to etcd version 3.4.34? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the changes look good to me. Thank you, @renormalize, for upgrading the etcd version.
Thanks for your review @seshachalam-yv! Regarding your comments:
|
* References to etcd-custom-image with version `v3.4.13-bootstrap-1` are now replaced with references to etcd-wrapper with version `v0.2.0`.
I've run etcd-druid e2e tests with changes proposed from this PR, along with the changes proposed in gardener/etcd-wrapper#30. I overrode the All tests pass.
|
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
LGTM
What this PR does / why we need it:
v3.4.34
.Restoration
API provided by etcd to trigger a restore instead of relying on copied code for restoration.v3.4.34
in the integration tests.Which issue(s) this PR fixes:
Fixes #792
Special notes for your reviewer:
Only commits beb9cbc and b849aaa have code changes which are relevant.
cc @seshachalam-yv
Release note: